linux-kernel - Re: [PATCH] cxl/mbox: Fix debug message print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <64c953697f857_2616829424@iweiny-mobl.notmuch>
Date:   Tue, 1 Aug 2023 11:48:09 -0700
From:   Ira Weiny <ira.weiny@...el.com>
To:     Alison Schofield <alison.schofield@...el.com>,
        Ira Weiny <ira.weiny@...el.com>
CC:     Davidlohr Bueso <dave@...olabs.net>,
        Jonathan Cameron <jonathan.cameron@...wei.com>,
        Dave Jiang <dave.jiang@...el.com>,
        "Vishal Verma" <vishal.l.verma@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        <linux-cxl@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cxl/mbox: Fix debug message print

Alison Schofield wrote:
> On Mon, Jul 31, 2023 at 01:52:27PM -0700, Ira Weiny wrote:
> 
> Looks like this is rolling for the distro list, so..
> 
> Please be more specific than this:
> [PATCH] cxl/mbox: Fix debug message print
> 
> Something like this is more useful to folks scanning the one-liners:
> [PATCH] cxl/mbox: Use correct handle in events debug message

That is better thanks!

> 
> > The handle value used to report an event being cleared by dev_dbg() is
> > incorrect due to a post increment of the payload handle index.
> > 
> > Delay the increment of the index until after the print.  Also add the
> > debugging for event processing which was useful in finding this bug.
> > 
> 
> "Also" always smells like something that should be a separate patch.

It could be but I did not see this as something which warranted its own
patch as it lead me to fix the bug.  Since Dan feels the fix should be
backported that changes my attitude.

> 
> I guess you could rewrite the commit message and keep it in one patch:
> [PATCH] cxl/mbox: Improve event dev_dbg() messages

Except that misses that this is a bug fix.

Ira