[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <54b4d761e5b16ffb798a89c1cea99714.sboyd@kernel.org>
Date: Tue, 01 Aug 2023 12:14:48 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Jonathan Neuschäfer <j.neuschaefer@....net>
Cc: Jonathan Neuschäfer <j.neuschaefer@....net>,
linux-clk@...r.kernel.org, openbmc@...ts.ozlabs.org,
linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
devicetree@...r.kernel.org,
Michael Turquette <mturquette@...libre.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Avi Fishman <avifishman70@...il.com>,
Tomer Maimon <tmaimon77@...il.com>,
Tali Perry <tali.perry1@...il.com>,
Patrick Venture <venture@...gle.com>,
Nancy Yuen <yuenn@...gle.com>,
Benjamin Fair <benjaminfair@...gle.com>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Thomas Gleixner <tglx@...utronix.de>,
Philipp Zabel <p.zabel@...gutronix.de>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Guenter Roeck <linux@...ck-us.net>,
Christophe JAILLET <christophe.jaillet@...adoo.fr>,
Joel Stanley <joel@....id.au>
Subject: Re: [PATCH v8 2/2] clk: wpcm450: Add Nuvoton WPCM450 clock/reset controller driver
Quoting Jonathan Neuschäfer (2023-07-22 08:15:43)
> On Thu, Jul 20, 2023 at 05:02:15PM -0700, Stephen Boyd wrote:
> > Quoting Jonathan Neuschäfer (2023-04-28 12:02:26)
> > > diff --git a/drivers/clk/clk-wpcm450.c b/drivers/clk/clk-wpcm450.c
> [...]
> > > +static unsigned long wpcm450_clk_pll_recalc_rate(struct clk_hw *hw,
> > > + unsigned long parent_rate)
> > > +{
> > > + struct wpcm450_clk_pll *pll = to_wpcm450_clk_pll(hw);
[...]
>
> > > +static const struct wpcm450_pll_data pll_data[] = {
> > > + { "pll0", { .name = "ref" }, REG_PLLCON0, 0 },
> >
> > This is new code, please don't use .name. Instead use .fw_name or .index with preference to
> > .index first and .hw if the pointer is available in this driver.
>
> As far as I can see, .fw_name and .index depend on a struct device*
> being passed to clk_hw_register, which won't be available unless I
> actually convert the driver to a platform driver.
You can call of_clk_hw_register(), but a conversion to a platform driver
is preferred.
>
> Not relying on .name would indeed be nice.
Cool.
Powered by blists - more mailing lists