linux-kernel - Re: [PATCH v3] ip6mr: Fix skb_under_panic in ip6mr_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230801131146.51a9aaf3@kernel.org>
Date:   Tue, 1 Aug 2023 13:11:46 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     Yue Haibing <yuehaibing@...wei.com>, davem@...emloft.net,
        dsahern@...nel.org, pabeni@...hat.com, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        simon.horman@...igine.com
Subject: Re: [PATCH v3] ip6mr: Fix skb_under_panic in ip6mr_cache_report()

On Tue, 1 Aug 2023 09:51:29 +0200 Eric Dumazet wrote:
> > -               skb_push(skb, -skb_network_offset(pkt));
> > +               __skb_pull(skb, skb_network_offset(pkt));
> >
> >                 skb_push(skb, sizeof(*msg));
> >                 skb_reset_transport_header(skb);  
> 
> Presumably this code has never been tested :/

Could have been tested on 32bit, I wonder if there is more such bugs :S