linux-kernel - Re: [PATCH] usb: dwc3: gadget: Let pm runtime get/put paired

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230801235616.i2k4rq4xroesuwbf@synopsys.com>
Date:   Tue, 1 Aug 2023 23:56:26 +0000
From:   Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Surong Pang <surong.pang@...soc.com>,
        "felipe.balbi@...ux.intel.com" <felipe.balbi@...ux.intel.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Orson.Zhai@...soc.com" <Orson.Zhai@...soc.com>,
        "Chunyan.Zhang@...soc.com" <Chunyan.Zhang@...soc.com>,
        "Zhiyong.liu@...soc.com" <Zhiyong.liu@...soc.com>,
        "Surong.Pang@...il.com" <Surong.Pang@...il.com>
Subject: Re: [PATCH] usb: dwc3: gadget: Let pm runtime get/put paired

On Tue, Aug 01, 2023, gregkh@...uxfoundation.org wrote:
> On Tue, Aug 01, 2023 at 12:49:24AM +0000, Thinh Nguyen wrote:
> > Hi,
> > 
> > On Mon, Jul 31, 2023, Surong Pang wrote:
> > > Pm_runtime_get is called when setting pending_events to true.
> > > Pm_runtime_put is needed for pairing with pm_runtime_get.
> > > 
> > > Fixes: fc8bb91bc83ef ("usb: dwc3: implement runtime PM")
> > 
> > Please fix your Fixes tag. Run checkpatch.pl before submit.
> 
> I don't see what's wrong with it, one extra character is just fine.
> 

This inconsistency bugs me a bit. :)

It's noted in the kernel documentation that it should be tagged with the
first 12 char of the commit id, and the checkpatch also complaints when
it's not.

Just trying to be consistent and request to run for checkpatch and fix
these things. If these issues should be ignored, I'll keep it in mind...

BR,
Thinh