linux-kernel - Re: [patch V2 50/58] x86/apic: Provide common init infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v8dzl0wm.ffs@tglx>
Date:   Tue, 01 Aug 2023 08:41:45 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Juergen Gross <jgross@...e.com>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     x86@...nel.org, Andrew Cooper <andrew.cooper3@...rix.com>,
        Tom Lendacky <thomas.lendacky@....com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Wei Liu <wei.liu@...nel.org>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Michael Kelley <mikelley@...rosoft.com>,
        Peter Keresztes Schmidt <peter@...esztesschmidt.de>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>
Subject: Re: [patch V2 50/58] x86/apic: Provide common init infrastructure

On Mon, Jul 31 2023 at 17:48, Thomas Gleixner wrote:

> On Mon, Jul 31 2023 at 15:10, Juergen Gross wrote:
>> On 31.07.23 15:01, Thomas Gleixner wrote:
>>>>    apic_driver(xen_pv_apic);
>>> 
>>> I wonder whether this explicit install is actually needed at all.
>>> Shouldn't the driver be installed via the APIC probing mechanism
>>> automagically?
>>
>> Only in case x86_init.irq.intr_mode_init is set appropriately. Today it is
>> a nop for Xen PV, but that can be changed. I'll have a look.
>
> You could simply set that callback to default_setup_apic_routing() and
> be done with it.

Doesn't work because XEN overrides it already. So sure, lets just go
with the solution you proposed. One more ugly or less in XEN/PV does not
really matter much :)

Let me grab this and put it into the right position in the queue.

Thanks,

        tglx