linux-kernel - Re: [PATCH] scsi: ufs: ufs-pci: Add support for QEMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230801092000epcms2p44c99d2c15bc6169e38693cb64cf946db@epcms2p4>
Date:   Tue, 01 Aug 2023 18:20:00 +0900
From:   Jeuk Kim <jeuk20.kim@...sung.com>
To:     Adrian Hunter <adrian.hunter@...el.com>
CC:     "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "avri.altman@....com" <avri.altman@....com>,
        "dlunev@...omium.org" <dlunev@...omium.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: ufs: ufs-pci: Add support for QEMU

On 1/08/23, Adrian Hunter wrote:
> On 1/08/23 10:37, Jeuk Kim wrote:
> > Add PCI ID to support QEMU ufs.
> > 
> > The new qemu ufs device can be found at
> > https://lore.kernel.org/qemu-devel/20230727155239.GA979354@fedora
> 
> Please say something about why a UFS device is being virtualized
> and what features it is expected to support.

Hi Adrian!

UFS device emulation feature has been newly added to QEMU recently.
Currently, QEMU UFS supports basic io and query request features,
and plans to add more features in the future.

With the addition of the QEMU ufs device emulation feature, 
QEMU UFS decided to use the pci device id of 0x0013 in the REDHAT vendor id (0x1b36).

However, this information is not registered in the linux ufs driver, 
so the current linux kernel does not recognize the QEMU UFS device. 
Therefore, I want to register the QEMU ufs pci id through this patch.

Do I need to add the above content to the commit message?

Thanks,
Jeuk

> > 
> > Signed-off-by: Jeuk Kim <jeuk20.kim@...sung.com>
> > ---
> >  drivers/ufs/host/ufshcd-pci.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/ufs/host/ufshcd-pci.c b/drivers/ufs/host/ufshcd-pci.c
> > index cf3987773051..29d322931427 100644
> > --- a/drivers/ufs/host/ufshcd-pci.c
> > +++ b/drivers/ufs/host/ufshcd-pci.c
> > @@ -590,6 +590,7 @@ static const struct dev_pm_ops ufshcd_pci_pm_ops = {
> >  };
> >  
> >  static const struct pci_device_id ufshcd_pci_tbl[] = {
> > +        { PCI_VENDOR_ID_REDHAT, 0x0013, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
> >          { PCI_VENDOR_ID_SAMSUNG, 0xC00C, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
> >          { PCI_VDEVICE(INTEL, 0x9DFA), (kernel_ulong_t)&ufs_intel_cnl_hba_vops },
> >          { PCI_VDEVICE(INTEL, 0x4B41), (kernel_ulong_t)&ufs_intel_ehl_hba_vops },