linux-kernel - Re: [PATCH V2] usb: dwc3: gadget: Let pm runtime get/put paired

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Jul 2023 18:33:04 -0700
From:   Elson Serrao <quic_eserrao@...cinc.com>
To:     Surong Pang <surong.pang@...soc.com>, <Thinh.Nguyen@...opsys.com>,
        <gregkh@...uxfoundation.org>, <felipe.balbi@...ux.intel.com>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <rogerq@...nel.org>
CC:     <Orson.Zhai@...soc.com>, <Chunyan.Zhang@...soc.com>,
        <Zhiyong.liu@...soc.com>, <Surong.Pang@...il.com>
Subject: Re: [PATCH V2] usb: dwc3: gadget: Let pm runtime get/put paired



On 7/31/2023 6:15 PM, Surong Pang wrote:
> Pm_runtime_get is called when setting pending_events to true.
> Pm_runtime_put is needed for pairing with pm_runtime_get.
> 
> Fixes: fc8bb91bc83e ("usb: dwc3: implement runtime PM")
> Signed-off-by: Surong Pang <surong.pang@...soc.com>
> 
> ---
> V2: add Fixes tag, fix Fixes tag
> ---
>   drivers/usb/dwc3/gadget.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 5fd067151fbf..9c835c5f9928 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
> @@ -4720,5 +4720,6 @@ void dwc3_gadget_process_pending_events(struct dwc3 *dwc)
>   		dwc3_interrupt(dwc->irq_gadget, dwc->ev_buf);
>   		dwc->pending_events = false;
>   		enable_irq(dwc->irq_gadget);
> +		pm_runtime_put(dwc->dev);
>   	}
>   }

I am already handling this change as part of below series. Will be 
uploading a separate patch based on the feedback from Roger.

https://lore.kernel.org/all/be57511d-2005-a1f5-d5a5-809e71029aec@quicinc.com/

Thanks
Elson