linux-kernel - Re: [v2] usb: common: usb-conn-gpio: Prevent bailing out if initial role is none

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <144125c0-4524-5617-dbb0-bf2575f56d4a@collabora.com>
Date:   Tue, 1 Aug 2023 12:50:08 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Prashanth K <quic_prashk@...cinc.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [v2] usb: common: usb-conn-gpio: Prevent bailing out if initial
 role is none

Il 01/08/23 08:01, Prashanth K ha scritto:
> Currently if we bootup a device without cable connected, then
> usb-conn-gpio won't call set_role() since last_role is same as
> current role. This happens because during probe last_role gets
> initialised to zero.
> 
> To avoid this, add a new flag initial_detection in the struct
> usb_conn_info, which prevents from bailing out during initial
> detection.
> 
> Fixes: 4602f3bff266 ("usb: common: add USB GPIO based connection detection driver")
> Signed-off-by: Prashanth K <quic_prashk@...cinc.com>

MediaTek platforms:

Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>