linux-kernel - Re: [PATCH v5 0/2] irqchip/loongson-eiointc: Add simple irq routing method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <92927822-1487-423b-cc08-fb728d07bb5c@loongson.cn>
Date:   Tue, 1 Aug 2023 09:42:53 +0800
From:   bibo mao <maobibo@...ngson.cn>
To:     Huacai Chen <chenhuacai@...nel.org>
Cc:     Marc Zyngier <maz@...nel.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Jianmin Lv <lvjianmin@...ngson.cn>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Philippe Mathieu-Daudé <philmd@...aro.org>
Subject: Re: [PATCH v5 0/2] irqchip/loongson-eiointc: Add simple irq routing
 method



在 2023/7/31 22:16, Huacai Chen 写道:
> On Wed, Jul 26, 2023 at 6:08 PM bibo mao <maobibo@...ngson.cn> wrote:
>>
>>
>>
>> 在 2023/7/26 17:53, Marc Zyngier 写道:
>>> On Wed, 26 Jul 2023 10:45:51 +0100,
>>> bibo mao <maobibo@...ngson.cn> wrote:
>>>>
>>>> slight ping :)
>>>
>>> Given that you have sent this series 5 times in two weeks, I don't
>>> think anyone is in a hurry to review it again. Just give it time.
>> Ok, I see.
>> Sorry to bring out some noise and thanks for your response.
> 1, If we really need a "virtual eiointc" variant, please document it
> in Documentation/loongarch/irq-chip-model.rst and
> Documentation/translations/zh_CN/loongarch/irq-chip-model.rst.
> 2, Then, I think it is better to only modify the type of 'index' in
> Patch-1, and move the 'if (index < 0) ...' modifications to Patch-2.
> Because all "virtual eiointc" code should be in a single patch.
sure, will do in this way.

Regards
Bibo Mao
> 
> 
> Huacai
>>
>> Regards
>> Bibo Mao
>>>
>>> Thanks,
>>>
>>>       M.
>>>
>>>>
>>>> 在 2023/7/19 14:35, Bibo Mao 写道:
>>>>> Fix return value checking of eiointc_index where int type
>>>>> is converted uint32_t and check smaller than 0.
>>>>>
>>>>> Add simple irq route support on system with only one eiointc node,
>>>>> rather than use anysend method.
>>>>>
>>>>> ---
>>>>> Changes in v5:
>>>>>   Modify typo issue.
>>>>>
>>>>> Changes in v4:
>>>>>   Modify some spell checking problems.
>>>>>   Add Fixes tag.
>>>>>
>>>>> Changes in v3:
>>>>>   Modify some spell checking problems.
>>>>>
>>>>> Changes in v2:
>>>>>   Use the simple irq routing on embeded board like 2K0500 and 2K2000
>>>>> board, since there is only one eio node.
>>>>>
>>>>> ---
>>>>> Bibo Mao (2):
>>>>>   irqchip/loongson-eiointc: Fix return value checking of eiointc_index
>>>>>   irqchip/loongson-eiointc: Simplify irq routing on some platforms
>>>>>
>>>>>  drivers/irqchip/irq-loongson-eiointc.c | 93 +++++++++++++++++++++++---
>>>>>  1 file changed, 82 insertions(+), 11 deletions(-)
>>>>>
>>>>
>>>>
>>>
>>