linux-kernel - Re: [PATCH] nvme: Don't fail to resume if NSIDs change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230801112403.GA3972@lst.de>
Date:   Tue, 1 Aug 2023 13:24:03 +0200
From:   Christoph Hellwig <hch@....de>
To:     "Limonciello, Mario" <mario.limonciello@....com>
Cc:     Christoph Hellwig <hch@....de>,
        August Wikerfors <git@...ustwikerfors.se>,
        Keith Busch <kbusch@...nel.org>, axboe@...com,
        sagi@...mberg.me, linux-nvme@...ts.infradead.org,
        linux-kernel@...r.kernel.org, nilskruse97@...il.com,
        David.Chang@....com
Subject: Re: [PATCH] nvme: Don't fail to resume if NSIDs change

On Mon, Jul 31, 2023 at 03:14:54PM -0500, Limonciello, Mario wrote:
>> No.  There are tons of NVMe devices that only support creating and
>> deleting namespace out of band, especially in virtualized and cloud
>> setups.
>
> Even if it's only the error handling path only that it's checked?

Do you mean nvme_validate_ns with the error code?  I wouldn't really call
that an error case, that's the function called to check namespaces are
still the same after we did a rescan (either manually or triggered by the
AEN).

> If you don't want more changes or heuristics on the error handling path for 
> this case, I think the best solution is probably to pick up
>
> https://lore.kernel.org/all/20221116171727.4083-1-git@augustwikerfors.se/t/
>
> instead then and hopefully we don't end up with more disks like this.

That's probably the better idea.  I know at least one of the early
quirked devices also IDs that changed for subsequent identify calls.