linux-kernel - Re: [PATCH] clk: qcom: fix some Kconfig corner cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <294d87a9-24a9-d802-2dbd-ae762a739a37@linaro.org>
Date:   Tue, 1 Aug 2023 13:28:02 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Arnd Bergmann <arnd@...nel.org>, Stephen Boyd <sboyd@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Bjorn Andersson <andersson@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Taniya Das <quic_tdas@...cinc.com>,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        Jagadeesh Kona <quic_jkona@...cinc.com>,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: qcom: fix some Kconfig corner cases

On 1.08.2023 12:56, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The SM_GCC_8550 symbol and others can only be built for ARM64 or when
> compile testing, but it gets selected by other drivers that can also be
> built for 32-bit ARCH_QCOM when not compile testing, which results in
> a Kconfig warning:
> 
> WARNING: unmet direct dependencies detected for SM_GCC_8550
>   Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=m] && (ARM64 || COMPILE_TEST [=n])
>   Selected by [m]:
>   - SM_GPUCC_8550 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m]
>   - SM_VIDEOCC_8550 [=m] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=m]
> 
> Add further 'depends on' statements to tighten this in a way that
> avoids the missing dependencies.
> 
> Fixes: fd0b5b106fcab ("clk: qcom: Introduce SM8350 VIDEOCC")
> Fixes: 441fe711be384 ("clk: qcom: videocc-sm8450: Add video clock controller driver for SM8450")
> Fixes: f53153a37969c ("clk: qcom: videocc-sm8550: Add video clock controller driver for SM8550")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad