linux-kernel - Re: [PATCH net-next v2] octeontx2: Remove unnecessary ternary operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6b2a52c8-041b-5dfc-8087-36b1d31c8dff@huawei.com>
Date:   Tue, 1 Aug 2023 19:28:53 +0800
From:   Ruan Jinjie <ruanjinjie@...wei.com>
To:     <jassisinghbrar@...il.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2] octeontx2: Remove unnecessary ternary
 operators

Sorry！the patch has sent incorrectly.

On 2023/8/1 19:24, Ruan Jinjie wrote:
> There are a little ternary operators, the true or false judgement
> of which is unnecessary in C language semantics. So remove it
> to clean Code.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> ---
> v2:
> - Fix the subject prefix and commit message issue.
> ---
>  drivers/net/ethernet/marvell/octeontx2/af/ptp.c      | 4 ++--
>  drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/ptp.c b/drivers/net/ethernet/marvell/octeontx2/af/ptp.c
> index 0ee420a489fc..c55c2c441a1a 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/ptp.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/ptp.c
> @@ -61,12 +61,12 @@ static const struct pci_device_id ptp_id_table[];
>  
>  static bool is_ptp_dev_cnf10kb(struct ptp *ptp)
>  {
> -	return (ptp->pdev->subsystem_device == PCI_SUBSYS_DEVID_CNF10K_B_PTP) ? true : false;
> +	return ptp->pdev->subsystem_device == PCI_SUBSYS_DEVID_CNF10K_B_PTP;
>  }
>  
>  static bool is_ptp_dev_cn10k(struct ptp *ptp)
>  {
> -	return (ptp->pdev->device == PCI_DEVID_CN10K_PTP) ? true : false;
> +	return ptp->pdev->device == PCI_DEVID_CN10K_PTP;
>  }
>  
>  static bool cn10k_ptp_errata(struct ptp *ptp)
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> index 9551b422622a..61f62a6ec662 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> @@ -2027,7 +2027,7 @@ u16 otx2_select_queue(struct net_device *netdev, struct sk_buff *skb,
>  #endif
>  	int txq;
>  
> -	qos_enabled = (netdev->real_num_tx_queues > pf->hw.tx_queues) ? true : false;
> +	qos_enabled = netdev->real_num_tx_queues > pf->hw.tx_queues;
>  	if (unlikely(qos_enabled)) {
>  		/* This smp_load_acquire() pairs with smp_store_release() in
>  		 * otx2_qos_root_add() called from htb offload root creation