linux-kernel - Re: [PATCH v3] usb: common: usb-conn-gpio: Prevent bailing out if initial role is none

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Aug 2023 17:23:13 +0530
From:   Prashanth K <quic_prashk@...cinc.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "# 5 . 4" <stable@...r.kernel.org>
Subject: Re: [PATCH v3] usb: common: usb-conn-gpio: Prevent bailing out if
 initial role is none



On 01-08-23 04:31 pm, AngeloGioacchino Del Regno wrote:
> Il 01/08/23 11:03, Prashanth K ha scritto:
>> Currently if we bootup a device without cable connected, then
>> usb-conn-gpio won't call set_role() because last_role is same
>> as current role. This happens since last_role gets initialised
>> to zero during the probe.
>>
>> To avoid this, add a new flag initial_detection into struct
>> usb_conn_info, which prevents bailing out during initial
>> detection.
>>
>> Cc: <stable@...r.kernel.org> # 5.4
>> Fixes: 4602f3bff266 ("usb: common: add USB GPIO based connection 
>> detection driver")
>> Signed-off-by: Prashanth K <quic_prashk@...cinc.com>
> 
> Just noticed that there was a v3, sent the T-b to the v2 erroneously, so:
> 
> MediaTek platforms
> 
> Tested-by: AngeloGioacchino Del Regno 
> <angelogioacchino.delregno@...labora.com>
> 
> 
Thanks AgneloGioacchino for testing.

Regards
Prashanth K