| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230801121824.174556-1-alistair.francis@wdc.com>
Date: Tue, 1 Aug 2023 08:18:24 -0400
From: Alistair Francis <alistair23@...il.com>
To: bhelgaas@...gle.com, linux-pci@...r.kernel.org,
Jonathan.Cameron@...wei.com, lukas@...ner.de
Cc: alex.williamson@...hat.com, christian.koenig@....com,
kch@...dia.com, gregkh@...uxfoundation.org, logang@...tatee.com,
linux-kernel@...r.kernel.org, alistair23@...il.com,
Alistair Francis <alistair.francis@....com>
Subject: [PATCH v2] PCI/DOE: Expose the DOE protocols via sysfs
The PCIe 6 specification added support for the Data Object Exchange (DOE).
When DOE is supported the Discovery Data Object Protocol must be
implemented. The protocol allows a requester to obtain information about
the other DOE protocols supported by the device.
The kernel is already querying the DOE protocols supported and cacheing
the values. This patch exposes the values via sysfs. This will allow
userspace to determine which DOE protocols are supported by the PCIe
device.
By exposing the information to userspace tools like lspci can relay the
information to users. By listing all of the supported protocols we can
allow userspace to parse and support the list, which might include
vendor specific protocols as well as yet to be supported protocols.
Signed-off-by: Alistair Francis <alistair.francis@....com>
---
Documentation/ABI/testing/sysfs-bus-pci | 11 ++++++
drivers/pci/doe.c | 52 +++++++++++++++++++++++++
drivers/pci/pci-sysfs.c | 8 ++++
include/linux/pci-doe.h | 2 +
4 files changed, 73 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-bus-pci b/Documentation/ABI/testing/sysfs-bus-pci
index ecf47559f495..ae969bbfa631 100644
--- a/Documentation/ABI/testing/sysfs-bus-pci
+++ b/Documentation/ABI/testing/sysfs-bus-pci
@@ -500,3 +500,14 @@ Description:
console drivers from the device. Raw users of pci-sysfs
resourceN attributes must be terminated prior to resizing.
Success of the resizing operation is not guaranteed.
+
+What: /sys/bus/pci/devices/.../doe_proto
+Date: July 2023
+Contact: Linux PCI developers <linux-pci@...r.kernel.org>
+Description:
+ This file contains a list of the supported Data Object Exchange (DOE)
+ protocols. The protocols are seperated by newlines.
+ The value comes from the device and specifies the vendor and
+ protocol supported. The lower byte is the protocol and the next
+ two bytes are the vendor ID.
+ The file is read only.
diff --git a/drivers/pci/doe.c b/drivers/pci/doe.c
index 1b97a5ab71a9..70900b79b239 100644
--- a/drivers/pci/doe.c
+++ b/drivers/pci/doe.c
@@ -563,6 +563,58 @@ static bool pci_doe_supports_prot(struct pci_doe_mb *doe_mb, u16 vid, u8 type)
return false;
}
+#ifdef CONFIG_SYSFS
+/**
+ * pci_doe_sysfs_proto_supports() - Write the supported DOE protocols
+ * to a sysfs buffer
+ * @doe_mb: DOE mailbox capability to query
+ * @buf: buffer to store the sysfs strings
+ * @offset: offset in buffer to store the sysfs strings
+ *
+ * RETURNS: The number of bytes written, 0 means an error occured
+ */
+static unsigned long pci_doe_sysfs_proto_supports(struct pci_doe_mb *doe_mb,
+ char *buf, ssize_t offset)
+{
+ unsigned long index;
+ ssize_t ret = offset;
+ ssize_t r;
+ void *entry;
+
+ xa_for_each(&doe_mb->prots, index, entry) {
+ r = sysfs_emit_at(buf, ret, "0x%08lX\n", xa_to_value(entry));
+
+ if (r == 0)
+ return ret;
+
+ ret += r;
+ }
+
+ return ret;
+}
+
+ssize_t doe_proto_show(struct device *dev, struct device_attribute *attr,
+ char *buf)
+{
+ struct pci_dev *pci_dev = to_pci_dev(dev);
+ unsigned long index;
+ ssize_t ret = 0;
+ ssize_t r;
+ struct pci_doe_mb *doe_mb;
+
+ xa_for_each(&pci_dev->doe_mbs, index, doe_mb) {
+ r = pci_doe_sysfs_proto_supports(doe_mb, buf, ret);
+
+ if (r == 0)
+ return ret;
+
+ ret += r;
+ }
+
+ return ret;
+}
+#endif
+
/**
* pci_doe_submit_task() - Submit a task to be processed by the state machine
*
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index ab32a91f287b..cdb6aea2d263 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -16,6 +16,7 @@
#include <linux/kernel.h>
#include <linux/sched.h>
#include <linux/pci.h>
+#include <linux/pci-doe.h>
#include <linux/stat.h>
#include <linux/export.h>
#include <linux/topology.h>
@@ -290,6 +291,10 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,
}
static DEVICE_ATTR_RO(modalias);
+#ifdef CONFIG_PCI_DOE
+static DEVICE_ATTR_RO(doe_proto);
+#endif
+
static ssize_t enable_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
{
@@ -603,6 +608,9 @@ static struct attribute *pci_dev_attrs[] = {
&dev_attr_local_cpus.attr,
&dev_attr_local_cpulist.attr,
&dev_attr_modalias.attr,
+#ifdef CONFIG_PCI_DOE
+ &dev_attr_doe_proto.attr,
+#endif
#ifdef CONFIG_NUMA
&dev_attr_numa_node.attr,
#endif
diff --git a/include/linux/pci-doe.h b/include/linux/pci-doe.h
index 1f14aed4354b..3033eb4bd17d 100644
--- a/include/linux/pci-doe.h
+++ b/include/linux/pci-doe.h
@@ -22,4 +22,6 @@ int pci_doe(struct pci_doe_mb *doe_mb, u16 vendor, u8 type,
const void *request, size_t request_sz,
void *response, size_t response_sz);
+ssize_t doe_proto_show(struct device *dev, struct device_attribute *attr,
+ char *buf);
#endif
--
2.41.0
Powered by blists - more mailing lists