linux-kernel - Re: ksys_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMj7zTwPw/qi/bNw@casper.infradead.org>
Date:   Tue, 1 Aug 2023 13:34:21 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        Christian Brauner <christian@...uner.io>,
        Andrey Grodzovsky <andrey.grodzovsky@....com>,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Alex Deucher <alexander.deucher@....com>,
        Hawking Zhang <Hawking.Zhang@....com>,
        Harry Pan <harry.pan@...el.com>, linux-pm@...r.kernel.org
Subject: Re: ksys_sync_helper

On Tue, Aug 01, 2023 at 04:07:18AM -0700, Christoph Hellwig wrote:
> On Mon, Jul 31, 2023 at 08:27:17PM +0200, Wysocki, Rafael J wrote:
> > 
> > OK, I'll remember about this.
> > 
> > 
> > > With this
> > > and commit d5ea093eebf022e now we end up with a random driver (amdgpu)
> > > syncing all file systems for absolutely no good reason.
> > 
> > Sorry about that.
> > 
> > The problematic commit should still revert more or less cleanly, so please
> > do that if that's what you need.
> 
> We'd still need to remove abuse in amdgpu first, though.

This would effectively revert d5ea093eebf0


diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index dc0e5227119b..af04fece37d5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -75,7 +75,6 @@
 #include "amdgpu_fru_eeprom.h"
 #include "amdgpu_reset.h"
 
-#include <linux/suspend.h>
 #include <drm/task_barrier.h>
 #include <linux/pm_runtime.h>
 
@@ -5225,17 +5224,6 @@ int amdgpu_device_gpu_recover(struct amdgpu_device *adev,
 	 */
 	need_emergency_restart = amdgpu_ras_need_emergency_restart(adev);
 
-	/*
-	 * Flush RAM to disk so that after reboot
-	 * the user can read log and see why the system rebooted.
-	 */
-	if (need_emergency_restart && amdgpu_ras_get_context(adev)->reboot) {
-		DRM_WARN("Emergency reboot.");
-
-		ksys_sync_helper();
-		emergency_restart();
-	}
-
 	dev_info(adev->dev, "GPU %s begin!\n",
 		need_emergency_restart ? "jobs stop":"reset");