linux-kernel - Re: [PATCH] s390/certstore: select CRYPTO_LIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57c5ba80-bc87-e76a-98f1-5f8043711b0a@infradead.org>
Date:   Mon, 31 Jul 2023 19:16:03 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Sven Schnelle <svens@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-next@...r.kernel.org,
        Anastasia Eskova <anastasia.eskova@....com>
Subject: Re: [PATCH] s390/certstore: select CRYPTO_LIB_SHA256



On 7/28/23 03:04, Sven Schnelle wrote:
> A build failure was reported when sha256() is not present:
> 
> gcc-13.1.0-nolibc/s390-linux/bin/s390-linux-ld: arch/s390/kernel/cert_store.o: in function `check_certificate_hash':
> arch/s390/kernel/cert_store.c:267: undefined reference to `sha256'
> 
> Therefore make CONFIG_CERT_STORE select CRYPTO_LIB_SHA256.
> 
> Fixes: 8cf57d7217c3 ("s390: add support for user-defined certificates")
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Closes: https://lore.kernel.org/all/8ecb57fb-4560-bdfc-9e55-63e3b0937132@infradead.org/
> Signed-off-by: Sven Schnelle <svens@...ux.ibm.com>

Sorry for the delay.

Tested-by: Randy Dunlap <rdunlap@...radead.org> # build-tested
Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  arch/s390/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> index d9d50a7a2016..18bf754e1fad 100644
> --- a/arch/s390/Kconfig
> +++ b/arch/s390/Kconfig
> @@ -516,6 +516,7 @@ config KEXEC_SIG
>  config CERT_STORE
>  	bool "Get user certificates via DIAG320"
>  	depends on KEYS
> +	select CRYPTO_LIB_SHA256
>  	help
>  	  Enable this option if you want to access user-provided secure boot
>  	  certificates via DIAG 0x320.

-- 
~Randy