linux-kernel - Re: [v1,v1,5/7] drm/vs: Register DRM device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00f8d896-7465-384c-dd94-823ad5524e50@loongson.cn>
Date:   Tue, 1 Aug 2023 21:53:38 +0800
From:   suijingfeng <suijingfeng@...ngson.cn>
To:     Keith Zhao <keith.zhao@...rfivetech.com>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
        linux-media@...r.kernel.org, linaro-mm-sig@...ts.linaro.org
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Emil Renner Berthing <kernel@...il.dk>,
        Shengyang Chen <shengyang.chen@...rfivetech.com>,
        Conor Dooley <conor+dt@...nel.org>,
        Albert Ou <aou@...s.berkeley.edu>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Maxime Ripard <mripard@...nel.org>,
        Jagan Teki <jagan@...eble.ai>,
        Rob Herring <robh+dt@...nel.org>,
        Chris Morgan <macromorgan@...mail.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Changhuang Liang <changhuang.liang@...rfivetech.com>,
        Jack Zhu <jack.zhu@...rfivetech.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Shawn Guo <shawnguo@...nel.org>, christian.koenig@....com
Subject: Re: [v1,v1,5/7] drm/vs: Register DRM device

Hi,

On 2023/8/1 21:40, suijingfeng wrote:
>> +if DRM_VERISILICON
>> +
>> +config STARFIVE_HDMI
>> +    bool "Starfive specific extensions HDMI"
>> +    help
>> +       This selects support for StarFive SoC specific extensions
>> +       for the Innosilicon HDMI driver. If you want to enable
>> +       HDMI on JH7110 based SoC, you should select this option.
>> +
>> +       To compile this driver as a module, choose M here.
>> +endif
>
> Why not use 

  Why not use the 'depends on DRM_VERISILICON'  here ?


```

config STARFIVE_HDMI

     depends on DRM_VERISILICON
     bool "Starfive specific extensions HDMI"

     help

```


I see the Kconfig of VC4 using the 'depends on', and most  driver using 
the 'depends on'