linux-kernel - Re: [PATCH] sched/rt: move back to RT_GROUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Aug 2023 10:00:30 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Yajun Deng <yajun.deng@...ux.dev>
Cc:     mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        bsegall@...gle.com, mgorman@...e.de, bristot@...hat.com,
        vschneid@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/rt: move back to RT_GROUP_SCHED and rename it
 child

On Tue,  1 Aug 2023 14:27:14 +0800
Yajun Deng <yajun.deng@...ux.dev> wrote:

> @@ -228,13 +228,10 @@ void init_tg_rt_entry(struct task_group *tg, struct rt_rq *rt_rq,
>  	if (!rt_se)
>  		return;
>  
> -	if (!parent)
> -		rt_se->rt_rq = &rq->rt;
> -	else
> -		rt_se->rt_rq = parent->my_q;
> -
> +	rt_se->rt_rq = parent->my_q;

So when this is called with parent = NULL, this will crash?

-- Steve

>  	rt_se->my_q = rt_rq;
>  	rt_se->parent = parent;
> +	parent->child = rt_se;
>  	INIT_LIST_HEAD(&rt_se->run_list);
>  }
>