[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <c46fe1bc-3170-4ab3-9de4-86d6877a004f@roeck-us.net>
Date: Wed, 2 Aug 2023 08:07:10 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Conor Dooley <conor.dooley@...rochip.com>
Cc: Carsten Spieß <mail@...sten-spiess.de>,
Conor Dooley <conor@...nel.org>,
Jean Delvare <jdelvare@...e.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Magnus Damm <magnus.damm@...il.com>,
linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: hwmon: add renesas,isl28022
On Wed, Aug 02, 2023 at 08:43:59AM +0100, Conor Dooley wrote:
> On Wed, Aug 02, 2023 at 09:30:23AM +0200, Carsten Spieß wrote:
> >
> > On 8/1/23 22:52, Conor Dooley wrote:
> > > On Tue, Aug 01, 2023 at 06:35:46PM +0200, Carsten Spieß wrote:
> > > > Add dt-bindings for Renesas ISL28022 power monitor.
> > > > +properties:
> > > > + compatible:
> > > > + enum:
> > > > + - renesas,isl28022
> > >
> > > You've only got one compatible, why the enum? Will there be more similar
> > > devices that have an incompatible programming model?
> > Yes, there are isl28023 and isl28025 with different register addresses,
> > might be supported in future releases.
>
> Right. Unless that's a very strong "might", const: will do the trick
> here just fine.
It is a very strong "will never be" for isl28023 and isl28025.
Guenter
>
> Otherwise,
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
>
> > > > + renesas,shunt-range-microvolt:
> > > > + description: |
> > >
> > > You don't need these |s if you have no formatting to preserve in the
> > > text.
> > Will fix in v4.
>
> There's no need to send a v4 for that alone.
Powered by blists - more mailing lists