linux-kernel - Re: [PATCH] scsi: ufs: qcom: Make struct ufs_qcom_bw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c6bd78b-c716-1c47-6d82-f6551e85251e@acm.org>
Date:   Wed, 2 Aug 2023 08:56:47 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        andersson@...nel.org, konrad.dybcio@...aro.org, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: ufs: qcom: Make struct ufs_qcom_bw_table static
 const

On 8/1/23 21:01, Manivannan Sadhasivam wrote:
> ufs_qcom_bw_table is not modified anywhere. So make it static const so that
> it can be placed in read-only memory.
> 
> Reported-by: Bart Van Assche <bvanassche@....org>
> Closes: https://lore.kernel.org/linux-scsi/43cd0057-c6d8-bc92-08f4-d767336d2cfe@acm.org/
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> ---
>   drivers/ufs/host/ufs-qcom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 75a1fd295f34..0341c025e818 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -58,7 +58,7 @@ enum {
>   	MODE_MAX,
>   };
>   
> -struct __ufs_qcom_bw_table {
> +static const struct __ufs_qcom_bw_table {
>   	u32 mem_bw;
>   	u32 cfg_bw;
>   } ufs_qcom_bw_table[MODE_MAX + 1][QCOM_UFS_MAX_GEAR + 1][QCOM_UFS_MAX_LANE + 1] = {

Thanks!

Reviewed-by: Bart Van Assche <bvanassche@....org>