linux-kernel - Re: [PATCH 1/1] rust: macros: fix redefine const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72muJwPHuJF++BYptO4_WVA=mU68nn=GWgqYo7pMdxC=pA@mail.gmail.com>
Date:   Wed, 2 Aug 2023 19:39:37 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Qingsong Chen <changxian.cqs@...group.com>
Cc:     linux-kernel@...r.kernel.org,
        田洪亮 <tate.thl@...group.com>,
        Miguel Ojeda <ojeda@...nel.org>,
        Alex Gaynor <alex.gaynor@...il.com>,
        Wedson Almeida Filho <wedsonaf@...il.com>,
        Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        Benno Lossin <benno.lossin@...ton.me>,
        Sergio González Collado <sergio.collado@...il.com>,
        rust-for-linux@...r.kernel.org
Subject: Re: [PATCH 1/1] rust: macros: fix redefine const_name in `vtable`

On Mon, Jun 26, 2023 at 9:48 AM Qingsong Chen
<changxian.cqs@...group.com> wrote:
>
> If the trait has same function name, the `vtable` macro
> will redefine its `gen_const_name`, e.g.:
> ```rust
>     #[vtable]
>     pub trait Foo {
>         #[cfg(CONFIG_X)]
>         fn bar();
>
>         #[cfg(not(CONFIG_X))]
>         fn bar(x: usize);
>     }
> ```
> Use `HashSet` to avoid this.
>
> Signed-off-by: Qingsong Chen <changxian.cqs@...group.com>

Applied to `rust-fixes`, thanks! I have reworded it with content from
the cover letter to make it more clear. Please double-check if it is
OK.

By the way, for single-patches, you don't need the cover letter,
especially if both have the same information like here (in fact, in
this case the cover letter was more clear, so it should have been part
of the commit message ideally).

Cheers,
Miguel