linux-kernel - Re: [PATCH 2/3] arm64: dts: ti: k3-am64: Merge the two main

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Aug 2023 12:47:12 -0500
From:   Andrew Davis <afd@...com>
To:     Nishanth Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>
CC:     <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] arm64: dts: ti: k3-am64: Merge the two main_conf
 nodes

On 8/2/23 12:45 PM, Andrew Davis wrote:
> There are two nodes representing the same register space, this looks to
> have been created by some merge or copy/paste error. Remove the second
> instance of this node and move its children into the first instance.
> 
> Signed-off-by: Andrew Davis <afd@...com>
> ---


Nishanth, this is based/dependent on your -next branch.

Andrew

>   arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 42 ++++++++++--------------
>   1 file changed, 17 insertions(+), 25 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> index d3dd8c426dada..e27eb2e585f14 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> @@ -44,11 +44,28 @@ main_conf: syscon@...00000 {
>   		#size-cells = <1>;
>   		ranges = <0x0 0x0 0x43000000 0x20000>;
>   
> +		chipid@14 {
> +			compatible = "ti,am654-chipid";
> +			reg = <0x00000014 0x4>;
> +		};
> +
>   		serdes_ln_ctrl: mux-controller {
>   			compatible = "mmio-mux";
>   			#mux-control-cells = <1>;
>   			mux-reg-masks = <0x4080 0x3>; /* SERDES0 lane0 select */
>   		};
> +
> +		phy_gmii_sel: phy@...4 {
> +			compatible = "ti,am654-phy-gmii-sel";
> +			reg = <0x4044 0x8>;
> +			#phy-cells = <1>;
> +		};
> +
> +		epwm_tbclk: clock@...0 {
> +			compatible = "ti,am64-epwm-tbclk";
> +			reg = <0x4130 0x4>;
> +			#clock-cells = <1>;
> +		};
>   	};
>   
>   	gic500: interrupt-controller@...0000 {
> @@ -203,31 +220,6 @@ main_pmx0: pinctrl@...00 {
>   		pinctrl-single,function-mask = <0xffffffff>;
>   	};
>   
> -	main_conf: syscon@...00000 {
> -		compatible = "syscon", "simple-mfd";
> -		reg = <0x00 0x43000000 0x00 0x20000>;
> -		#address-cells = <1>;
> -		#size-cells = <1>;
> -		ranges = <0x00 0x00 0x43000000 0x20000>;
> -
> -		chipid@14 {
> -			compatible = "ti,am654-chipid";
> -			reg = <0x00000014 0x4>;
> -		};
> -
> -		phy_gmii_sel: phy@...4 {
> -			compatible = "ti,am654-phy-gmii-sel";
> -			reg = <0x4044 0x8>;
> -			#phy-cells = <1>;
> -		};
> -
> -		epwm_tbclk: clock@...0 {
> -			compatible = "ti,am64-epwm-tbclk";
> -			reg = <0x4130 0x4>;
> -			#clock-cells = <1>;
> -		};
> -	};
> -
>   	main_timer0: timer@...0000 {
>   		compatible = "ti,am654-timer";
>   		reg = <0x00 0x2400000 0x00 0x400>;