linux-kernel - Re: [PATCH] platform/chrome: cros_ec_lpc: Remove EC panic shutdown timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABXOdTd0B2YwXkrr6t7Mx-LwOuV+9O9Q91P7M_=8d3iqGQ+=cg@mail.gmail.com>
Date:   Wed, 2 Aug 2023 11:54:41 -0700
From:   Guenter Roeck <groeck@...gle.com>
To:     Rob Barnes <robbarnes@...gle.com>
Cc:     bleung@...omium.org, groeck@...omium.org, tzungbi@...nel.org,
        dtor@...omium.org, chrome-platform@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/chrome: cros_ec_lpc: Remove EC panic shutdown timeout

On Wed, Aug 2, 2023 at 10:59 AM Rob Barnes <robbarnes@...gle.com> wrote:
>
> Remove the 1 second timeout applied to hw_protection_shutdown after an
> EC panic. On some platforms this 1 second timeout is insufficient to
> allow the filesystem to fully sync. Independently the EC will force a
> full system reset after a short period. So this backup timeout is
> unnecessary.
>
> Signed-off-by: Rob Barnes <robbarnes@...gle.com>

Reviewed-by: Guenter Roeck <groeck@...omium.org>

> ---
>
>  drivers/platform/chrome/cros_ec_lpc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
> index 500a61b093e47..356572452898d 100644
> --- a/drivers/platform/chrome/cros_ec_lpc.c
> +++ b/drivers/platform/chrome/cros_ec_lpc.c
> @@ -327,8 +327,8 @@ static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data)
>                 dev_emerg(ec_dev->dev, "CrOS EC Panic Reported. Shutdown is imminent!");
>                 blocking_notifier_call_chain(&ec_dev->panic_notifier, 0, ec_dev);
>                 kobject_uevent_env(&ec_dev->dev->kobj, KOBJ_CHANGE, (char **)env);
> -               /* Begin orderly shutdown. Force shutdown after 1 second. */
> -               hw_protection_shutdown("CrOS EC Panic", 1000);
> +               /* Begin orderly shutdown. EC will force reset after a short period. */
> +               hw_protection_shutdown("CrOS EC Panic", -1);
>                 /* Do not query for other events after a panic is reported */
>                 return;
>         }
> --
> 2.41.0.585.gd2178a4bd4-goog
>