linux-kernel - Re: [PATCH] KVM: x86/mmu: Move the lockdep_assert of mmu_lock to inside clear_dirty_pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <169084279326.1259481.1489304678823959902.b4-ty@google.com>
Date:   Wed,  2 Aug 2023 12:17:26 -0700
From:   Sean Christopherson <seanjc@...gle.com>
To:     Sean Christopherson <seanjc@...gle.com>,
        Like Xu <like.xu.linux@...il.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: x86/mmu: Move the lockdep_assert of mmu_lock to
 inside clear_dirty_pt_masked()

On Tue, 27 Jun 2023 12:26:39 +0800, Like Xu wrote:
> Move the lockdep_assert_held_write(&kvm->mmu_lock) from the only one caller
> kvm_tdp_mmu_clear_dirty_pt_masked() to inside clear_dirty_pt_masked().
> 
> This change makes it more obvious why it's safe for clear_dirty_pt_masked()
> to use the non-atomic (for non-volatile SPTEs) tdp_mmu_clear_spte_bits()
> helper. for_each_tdp_mmu_root() does its own lockdep, so the only "loss"
> in lockdep coverage is if the list is completely empty.
> 
> [...]

Applied to kvm-x86 mmu, thanks!

[1/1] KVM: x86/mmu: Move the lockdep_assert of mmu_lock to inside clear_dirty_pt_masked()
      https://github.com/kvm-x86/linux/commit/e19314998321

--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes