linux-kernel - Re: [PATCH 1/1] rust: macros: fix redefine const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230802195020.3062950-1-aliceryhl@google.com>
Date:   Wed,  2 Aug 2023 19:50:20 +0000
From:   Alice Ryhl <aliceryhl@...gle.com>
To:     changxian.cqs@...group.com
Cc:     alex.gaynor@...il.com, benno.lossin@...ton.me,
        bjorn3_gh@...tonmail.com, boqun.feng@...il.com, gary@...yguo.net,
        linux-kernel@...r.kernel.org, ojeda@...nel.org,
        rust-for-linux@...r.kernel.org, sergio.collado@...il.com,
        tate.thl@...group.com, wedsonaf@...il.com
Subject: Re: [PATCH 1/1] rust: macros: fix redefine const_name in `vtable`

Qingsong Chen <changxian.cqs@...group.com> writes:
>      let mut body_it = body.stream().into_iter();
> -    let mut functions = Vec::new();
> +    let mut functions = HashSet::new();

Please use a `BTreeSet` instead of a `HashSet`. A `HashSet` has
non-deterministic iteration order, so this will make the macro output
different things each time you run it.

Alice