linux-kernel - RE: [PATCH] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SN4PR18MB49189350D03D4DF4A976B8DBE30BA@SN4PR18MB4918.namprd18.prod.outlook.com>
Date:   Wed, 2 Aug 2023 20:47:48 +0000
From:   Patrick Whewell <patrick.whewell@...htlineapplications.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>
CC:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        William Gray <william.gray@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Taniya Das <tdas@...eaurora.org>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Venkata Narendra Kumar Gutta <vnkgutta@...eaurora.org>,
        Vinod Koul <vkoul@...nel.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] clk: qcom: gcc-sm8250: Fix gcc_sdcc2_apps_clk_src

On Friday, July 28, 2023 12:24 PM, Konrad Dybcio wrote:
> On 28.07.2023 21:14, Patrick Whewell wrote:
> > Set .flags = CLK_OPS_PARENT_ENABLE to fix "gcc_sdcc2_apps_clk_src: rcg
> > didn't update its configuration" error.
> >
> > Signed-off-by: Patrick Whewell
> > <patrick.whewell@...htlineapplications.com>
> > Fixes: 3e5770921a88 ("clk: qcom: gcc: Add global clock controller
> > driver for SM8250")
> > ---
> Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> 
> You could also mention that the error is caused by GPLL9 (the one providing
> the highest frequency in the freq table) not being on by default.
> 
> And ultra nit: your s-o-b should go last

I will be sending over v2 shortly with both comments addressed.

> 
> Konrad
> >  drivers/clk/qcom/gcc-sm8250.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/qcom/gcc-sm8250.c
> > b/drivers/clk/qcom/gcc-sm8250.c index b6cf4bc88d4d..d3c75bb55946
> > 100644
> > --- a/drivers/clk/qcom/gcc-sm8250.c
> > +++ b/drivers/clk/qcom/gcc-sm8250.c
> > @@ -721,6 +721,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = {
> >  		.name = "gcc_sdcc2_apps_clk_src",
> >  		.parent_data = gcc_parent_data_4,
> >  		.num_parents = ARRAY_SIZE(gcc_parent_data_4),
> > +		.flags = CLK_OPS_PARENT_ENABLE,
> >  		.ops = &clk_rcg2_floor_ops,
> >  	},
> >  };