[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD=FV=VvzdgmMYjeg=RAu-4OEA9mkB7Xu_jjMF-LkBzCP=qQ1A@mail.gmail.com>
Date: Wed, 2 Aug 2023 13:53:14 -0700
From: Doug Anderson <dianders@...omium.org>
To: Sheng-Liang Pan <sheng-liang.pan@...nta.corp-partner.google.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
cros-qcom-dts-watchers@...omium.org, devicetree@...r.kernel.org,
linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: qcom: Add sku_id for lazor/limozeen
Hi,
On Wed, Aug 2, 2023 at 2:58 AM Sheng-Liang Pan
<sheng-liang.pan@...nta.corp-partner.google.com> wrote:
>
> SKU ID 10: Lazor LTE+Wifi, no-esim (Strapped 0 X 0)
> SKU ID 15: Limozeen LTE+Wifi, TS, no esim (Strapped 1 X 0)
> SKU ID 18: Limozeen LTE+Wifi, no TS, no esim (Strapped X 0 0)
>
> Even though the "no esim" boards are strapped differently than
> ones that have an esim, the esim isn't represented in the
> device tree so the same device tree can be used for LTE w/ esim
> and LTE w/out esim.
>
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@...nta.corp-partner.google.com>
> ---
>
> .../boot/dts/qcom/sc7180-trogdor-lazor-limozeen-nots-r9.dts | 2 +-
> arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-limozeen-r9.dts | 2 +-
> arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r9-lte.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
Looks fine to me. One nit is that in the ${SUBJECT} you probably want
"sc7180", so:
arm64: dts: qcom: sc7180: Add sku_id for lazor/limozeen
Once that's fixed feel free to include:
Reviewed-by: Douglas Anderson <dianders@...omium.org>
Powered by blists - more mailing lists