linux-kernel - Re: [PATCH] gpio: sama5d2-piobu: remove unneeded call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bdcffc0f-5bd7-d6e5-74a1-ae5f934af3ff@tuxon.dev>
Date:   Wed, 2 Aug 2023 07:42:17 +0300
From:   claudiu beznea <claudiu.beznea@...on.dev>
To:     Andrei Coardos <aboutphysycs@...il.com>,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Cc:     andy@...nel.org, brgl@...ev.pl, linus.walleij@...aro.org,
        ludovic.desroches@...rochip.com,
        Alexandru Ardelean <alex@...uggie.ro>
Subject: Re: [PATCH] gpio: sama5d2-piobu: remove unneeded call to
 platform_set_drvdata()



On 28.07.2023 21:25, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
> 
> Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...on.dev>

> ---
>  drivers/gpio/gpio-sama5d2-piobu.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-sama5d2-piobu.c b/drivers/gpio/gpio-sama5d2-piobu.c
> index 767c33ae3213..d89da7300ddd 100644
> --- a/drivers/gpio/gpio-sama5d2-piobu.c
> +++ b/drivers/gpio/gpio-sama5d2-piobu.c
> @@ -189,7 +189,6 @@ static int sama5d2_piobu_probe(struct platform_device *pdev)
>  	if (!piobu)
>  		return -ENOMEM;
>  
> -	platform_set_drvdata(pdev, piobu);
>  	piobu->chip.label = pdev->name;
>  	piobu->chip.parent = &pdev->dev;
>  	piobu->chip.owner = THIS_MODULE,