[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230802093023.1a926c9f.mail@carsten-spiess.de>
Date: Wed, 2 Aug 2023 09:30:23 +0200
From: Carsten Spieß <mail@...sten-spiess.de>
To: Conor Dooley <conor@...nel.org>
Cc: Jean Delvare <jdelvare@...e.com>,
Guenter Roeck <linux@...ck-us.net>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Magnus Damm <magnus.damm@...il.com>,
linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: hwmon: add renesas,isl28022
On 8/1/23 22:52, Conor Dooley wrote:
> On Tue, Aug 01, 2023 at 06:35:46PM +0200, Carsten Spieß wrote:
> > Add dt-bindings for Renesas ISL28022 power monitor.
> > +properties:
> > + compatible:
> > + enum:
> > + - renesas,isl28022
>
> You've only got one compatible, why the enum? Will there be more similar
> devices that have an incompatible programming model?
Yes, there are isl28023 and isl28025 with different register addresses,
might be supported in future releases.
> > + renesas,shunt-range-microvolt:
> > + description: |
>
> You don't need these |s if you have no formatting to preserve in the
> text.
Will fix in v4.
> Otherwise, this does look good to me.
Thanks, regards
Carsten
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists