linux-kernel - Re: [PATCH] drm/panel: samsung-s6d7aa0: Add MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32876ecc-4f20-2b59-937d-7923a4d20594@linaro.org>
Date:   Wed, 2 Aug 2023 10:01:29 +0200
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Nikita Travkin <nikita@...n.ru>,
        Artur Weber <aweber.kernel@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel: samsung-s6d7aa0: Add MODULE_DEVICE_TABLE

On 02/08/2023 08:41, Nikita Travkin wrote:
> The driver can be built as a module, however the lack of the
> MODULE_DEVICE_TABLE macro prevents it from being automatically probed
> from the DT in such case.
> 
> Add the missed macro to make sure the module can load automatically.
> 
> Fixes: 6810bb390282 ("drm/panel: Add Samsung S6D7AA0 panel controller driver")
> Signed-off-by: Nikita Travkin <nikita@...n.ru>
> ---
>   drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
> index 0583360b1280..ea5a85779382 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
> @@ -567,6 +567,7 @@ static const struct of_device_id s6d7aa0_of_match[] = {
>   	},
>   	{ /* sentinel */ }
>   };
> +MODULE_DEVICE_TABLE(of, s6d7aa0_of_match);
>   
>   static struct mipi_dsi_driver s6d7aa0_driver = {
>   	.probe = s6d7aa0_probe,
> 
> ---
> base-commit: 626c67169f9972fffcdf3bc3864de421f162ebf5
> change-id: 20230802-gt5-panel-dtable-d9d6ca407f26
> 
> Best regards,

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>