[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <859a2d3e-a892-b02e-db1a-ca2503b8952b@linux.intel.com>
Date: Wed, 2 Aug 2023 16:11:47 +0800
From: Baolu Lu <baolu.lu@...ux.intel.com>
To: "Tian, Kevin" <kevin.tian@...el.com>,
"Liu, Yi L" <yi.l.liu@...el.com>,
"joro@...tes.org" <joro@...tes.org>,
"alex.williamson@...hat.com" <alex.williamson@...hat.com>,
"jgg@...dia.com" <jgg@...dia.com>,
"robin.murphy@....com" <robin.murphy@....com>
Cc: baolu.lu@...ux.intel.com, "cohuck@...hat.com" <cohuck@...hat.com>,
"eric.auger@...hat.com" <eric.auger@...hat.com>,
"nicolinc@...dia.com" <nicolinc@...dia.com>,
"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
"mjrosato@...ux.ibm.com" <mjrosato@...ux.ibm.com>,
"chao.p.peng@...ux.intel.com" <chao.p.peng@...ux.intel.com>,
"yi.y.sun@...ux.intel.com" <yi.y.sun@...ux.intel.com>,
"peterx@...hat.com" <peterx@...hat.com>,
"jasowang@...hat.com" <jasowang@...hat.com>,
"shameerali.kolothum.thodi@...wei.com"
<shameerali.kolothum.thodi@...wei.com>,
"lulu@...hat.com" <lulu@...hat.com>,
"suravee.suthikulpanit@....com" <suravee.suthikulpanit@....com>,
"iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
"Duan, Zhenzhong" <zhenzhong.duan@...el.com>,
Jacob Pan <jacob.jun.pan@...ux.intel.com>
Subject: Re: [PATCH v4 04/12] iommu/vt-d: Add helper to setup pasid nested
translation
On 2023/8/2 16:09, Baolu Lu wrote:
> On 2023/8/2 15:10, Tian, Kevin wrote:
>>> +
>>> + pasid_set_slptr(pte, virt_to_phys(pgd));
>>> + pasid_set_fault_enable(pte);
>>> + pasid_set_domain_id(pte, did);
>>> + pasid_set_address_width(pte, s2_domain->agaw);
>>> + pasid_set_page_snoop(pte, !!ecap_smpwc(iommu->ecap));
>>> + pasid_set_translation_type(pte, PASID_ENTRY_PGTT_NESTED);
>>> + pasid_set_present(pte);
>>> + spin_unlock(&iommu->lock);
>>> +
>> this lacks of handling of force_snooping
>
> If stage-2 domain has force_snooping attribute set, then we should set
> the bit field in the pasid entry, right?
>
> How about below additional change?
>
> diff --git a/drivers/iommu/intel/pasid.c b/drivers/iommu/intel/pasid.c
> index 19ac4084913b..86db81ec91f1 100644
> --- a/drivers/iommu/intel/pasid.c
> +++ b/drivers/iommu/intel/pasid.c
> @@ -827,6 +827,9 @@ int intel_pasid_setup_nested(struct intel_iommu
> *iommu, struct device *dev,
> if (s1_cfg->flags & IOMMU_VTD_S1_EAFE)
> pasid_set_eafe(pte);
>
> + if (s2_domain>force_snooping)
+ if (s2_domain->force_snooping)
Sorry for typo.
> + pasid_set_pgsnp(pte);
> +
> pasid_set_slptr(pte, virt_to_phys(pgd));
> pasid_set_fault_enable(pte);
> pasid_set_domain_id(pte, did);
>
> Best regards,
> baolu
Powered by blists - more mailing lists