[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <599b845c-80d9-467c-b9ac-2ce844ee256e@app.fastmail.com>
Date: Wed, 02 Aug 2023 10:31:54 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Christoph Hellwig" <hch@....de>,
"Luis Chamberlain" <mcgrof@...nel.org>,
"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
"Daniel Mack" <daniel@...que.org>,
"Haojian Zhuang" <haojian.zhuang@...il.com>,
"Robert Jarzmik" <robert.jarzmik@...e.fr>,
"Ulf Hansson" <ulf.hansson@...aro.org>,
"Manuel Lauss" <manuel.lauss@...il.com>,
"Yangbo Lu" <yangbo.lu@....com>, "Joshua Kinard" <kumba@...too.org>
Cc: "Daniel Vetter" <daniel.vetter@...ll.ch>,
linux-arm-kernel@...ts.infradead.org,
"open list" <linux-kernel@...r.kernel.org>,
"linux-mmc @ vger . kernel . org" <linux-mmc@...r.kernel.org>,
Netdev <netdev@...r.kernel.org>, linux-rtc@...r.kernel.org,
linux-modules@...r.kernel.org
Subject: Re: [PATCH 2/5] mmc: au1xmmc: force non-modular build and remove symbol_get
usage
On Tue, Aug 1, 2023, at 19:35, Christoph Hellwig wrote:
> au1xmmc is split somewhat awkwardly into the main mmc subsystem driver,
> and callbacks in platform_data that sit under arch/mips/ and are
> always built in. The latter than call mmc_detect_change through
> symbol_get. Remove the use of symbol_get by requiring the driver
> to be built in. In the future the interrupt handlers for card
> insert/eject detection should probably be moved into the main driver,
> and which point it can be built modular again.
>
> Signed-off-by: Christoph Hellwig <hch@....de>
Good idea.
> of Alcor Micro PCI-E card reader
>
> config MMC_AU1X
> - tristate "Alchemy AU1XX0 MMC Card Interface support"
> + bool "Alchemy AU1XX0 MMC Card Interface support"
> depends on MIPS_ALCHEMY
> help
This needs a
depends on MMC=y
otherwise you get a link failure with CONFIG_MMC=m and
CONFIG_MMC_AU1X=y.
With that fixed,
Reviewed-by: Arnd Bergmann <arnd@...db.de>
Powered by blists - more mailing lists