[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6f9f11ea-ad08-13e4-f5ba-1a3b7668d70d@quicinc.com>
Date: Wed, 2 Aug 2023 14:25:56 +0530
From: Komal Bajaj <quic_kbajaj@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>, <agross@...nel.org>,
<andersson@...nel.org>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
<srinivas.kandagatla@...aro.org>
CC: <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 5/6] soc: qcom: llcc: Updating the macro name
On 7/24/2023 6:18 PM, Konrad Dybcio wrote:
> On 24.07.2023 10:41, Komal Bajaj wrote:
>> Updating macro name for LLCC_DRE to LLCC_ECC as per
>> the latest specification.
>>
>> Signed-off-by: Komal Bajaj <quic_kbajaj@...cinc.com>
>> ---
> Nit: "updating" -> "update", as the action is complete.
>
> On top of that, please wrap your commit messages at +/- 72 characters,
> not 50.
Sure, will update the commit message.
Thanks
Komal
>
> Acked-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>
> Konrad
>> drivers/soc/qcom/llcc-qcom.c | 2 +-
>> include/linux/soc/qcom/llcc-qcom.h | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
>> index 1d2b08dfecea..228ffb4a8971 100644
>> --- a/drivers/soc/qcom/llcc-qcom.c
>> +++ b/drivers/soc/qcom/llcc-qcom.c
>> @@ -193,7 +193,7 @@ static const struct llcc_slice_config sc8280xp_data[] = {
>> { LLCC_MMUHWT, 13, 1024, 1, 1, 0xfff, 0x0, 0, 0, 0, 0, 1, 0 },
>> { LLCC_DISP, 16, 6144, 1, 1, 0xfff, 0x0, 0, 0, 0, 1, 0, 0 },
>> { LLCC_AUDHW, 22, 2048, 1, 1, 0xfff, 0x0, 0, 0, 0, 1, 0, 0 },
>> - { LLCC_DRE, 26, 1024, 1, 1, 0xfff, 0x0, 0, 0, 0, 1, 0, 0 },
>> + { LLCC_ECC, 26, 1024, 1, 1, 0xfff, 0x0, 0, 0, 0, 1, 0, 0 },
>> { LLCC_CVP, 28, 512, 3, 1, 0xfff, 0x0, 0, 0, 0, 1, 0, 0 },
>> { LLCC_APTCM, 30, 1024, 3, 1, 0x0, 0x1, 1, 0, 0, 1, 0, 0 },
>> { LLCC_WRCACHE, 31, 1024, 1, 1, 0xfff, 0x0, 0, 0, 0, 0, 1, 0 },
>> diff --git a/include/linux/soc/qcom/llcc-qcom.h b/include/linux/soc/qcom/llcc-qcom.h
>> index 93417ba1ead4..1a886666bbb6 100644
>> --- a/include/linux/soc/qcom/llcc-qcom.h
>> +++ b/include/linux/soc/qcom/llcc-qcom.h
>> @@ -30,7 +30,7 @@
>> #define LLCC_NPU 23
>> #define LLCC_WLHW 24
>> #define LLCC_PIMEM 25
>> -#define LLCC_DRE 26
>> +#define LLCC_ECC 26
>> #define LLCC_CVP 28
>> #define LLCC_MODPE 29
>> #define LLCC_APTCM 30
Powered by blists - more mailing lists