linux-kernel - Re: [PATCH -next] drm/msm: Remove redundant DRM_DEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <131f9c51-10d6-c4b4-4e7f-c3c30480d385@linaro.org>
Date:   Wed, 2 Aug 2023 12:35:49 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Ruan Jinjie <ruanjinjie@...wei.com>, robdclark@...il.com,
        quic_abhinavk@...cinc.com, sean@...rly.run,
        marijn.suijten@...ainline.org, airlied@...il.com, daniel@...ll.ch,
        quic_jesszhan@...cinc.com, dri-devel@...ts.freedesktop.org,
        freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drm/msm: Remove redundant DRM_DEV_ERROR()

On 27/07/2023 14:24, Ruan Jinjie wrote:
> There is no need to call the DRM_DEV_ERROR() function directly to print
> a custom message when handling an error from platform_get_irq() function
> as it is going to display an appropriate error message
> in case of a failure.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com>
> ---
>   drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 1 -
>   drivers/gpu/drm/msm/msm_gpu.c            | 1 -
>   2 files changed, 2 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

-- 
With best wishes
Dmitry