linux-kernel - Re: XFS metadata CRC errors on zram block device on ppc64le architecture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230802094106.GA28187@lst.de>
Date:   Wed, 2 Aug 2023 11:41:06 +0200
From:   Christoph Hellwig <hch@....de>
To:     Dusty Mabe <dusty@...tymabe.com>
Cc:     Minchan Kim <minchan@...nel.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org,
        linux-block@...r.kernel.org, Christoph Hellwig <hch@....de>,
        Andrew Morton <akpm@...ux-foundation.org>, marmijo@...hat.com
Subject: Re: XFS metadata CRC errors on zram block device on ppc64le
 architecture

On Tue, Aug 01, 2023 at 11:31:37PM -0400, Dusty Mabe wrote:
> We ran a kernel bisect and narrowed it down to offending commit af8b04c6:
> 
> ```
> [root@...-p8-kvm-03-guest-02 linux]# git bisect good
> af8b04c63708fa730c0257084fab91fb2a9cecc4 is the first bad commit
> commit af8b04c63708fa730c0257084fab91fb2a9cecc4
> Author: Christoph Hellwig <hch@....de>
> Date:   Tue Apr 11 19:14:46 2023 +0200
> 
>     zram: simplify bvec iteration in __zram_make_request
>     
>     bio_for_each_segment synthetize bvecs that never cross page boundaries, so
>     don't duplicate that work in an inner loop.

> Any ideas on how to fix the problem?

So the interesting cases are:

  - ppc64 usually uses 64k page sizes
  - ppc64 is somewhat cache incoherent (compared to say x86)

Let me think of this a bit more.