[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230802095737.3957587-4-liaochang1@huawei.com>
Date: Wed, 2 Aug 2023 17:57:31 +0800
From: Liao Chang <liaochang1@...wei.com>
To: <andi.shyti@...nel.org>, <florian.fainelli@...adcom.com>,
<bcm-kernel-feedback-list@...adcom.com>, <rjui@...adcom.com>,
<sbranden@...adcom.com>, <yangyicong@...ilicon.com>,
<aisheng.dong@....com>, <shawnguo@...nel.org>,
<s.hauer@...gutronix.de>, <kernel@...gutronix.de>,
<festevam@...il.com>, <linux-imx@....com>, <kblaiech@...dia.com>,
<asmaa@...dia.com>, <loic.poulain@...aro.org>, <rfoss@...nel.org>,
<ardb@...nel.org>, <gcherian@...vell.com>
CC: <linux-i2c@...r.kernel.org>,
<linux-rpi-kernel@...ts.infradead.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>
Subject: [PATCH 3/9] i2c: xlp9xx: Use dev_err_probe in probe function
Use the dev_err_probe function instead of dev_err in the probe function
so that the printed messge includes the return value and also handles
-EPROBE_DEFER nicely.
Reviewed-by: Andi Shyti <andi.shyti@...nel.org>
Signed-off-by: Liao Chang <liaochang1@...wei.com>
---
drivers/i2c/busses/i2c-xlp9xx.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-xlp9xx.c b/drivers/i2c/busses/i2c-xlp9xx.c
index f59e8c544f36..08a59a920929 100644
--- a/drivers/i2c/busses/i2c-xlp9xx.c
+++ b/drivers/i2c/busses/i2c-xlp9xx.c
@@ -529,10 +529,8 @@ static int xlp9xx_i2c_probe(struct platform_device *pdev)
err = devm_request_irq(&pdev->dev, priv->irq, xlp9xx_i2c_isr, 0,
pdev->name, priv);
- if (err) {
- dev_err(&pdev->dev, "IRQ request failed!\n");
- return err;
- }
+ if (err)
+ return dev_err_probe(&pdev->dev, err, "IRQ request failed!\n");
init_completion(&priv->msg_complete);
priv->adapter.dev.parent = &pdev->dev;
--
2.25.1
Powered by blists - more mailing lists