linux-kernel - Re: [PATCH 3/3] clk: qcom: add clock controller driver for qca8386/qca8084

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8556fd68-edb1-5b97-6472-ae854f86190b@quicinc.com>
Date:   Wed, 2 Aug 2023 18:34:04 +0800
From:   Jie Luo <quic_luoj@...cinc.com>
To:     Randy Dunlap <rdunlap@...radead.org>, <agross@...nel.org>,
        <andersson@...nel.org>, <konrad.dybcio@...aro.org>,
        <mturquette@...libre.com>, <sboyd@...nel.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <conor+dt@...nel.org>, <p.zabel@...gutronix.de>
CC:     <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_srichara@...cinc.com>
Subject: Re: [PATCH 3/3] clk: qcom: add clock controller driver for
 qca8386/qca8084



On 8/2/2023 3:16 AM, Randy Dunlap wrote:
> 
> 
> On 8/1/23 01:53, Luo Jie wrote:
>> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
>> index 263e55d75e3f..a17e8fa5a7e1 100644
>> --- a/drivers/clk/qcom/Kconfig
>> +++ b/drivers/clk/qcom/Kconfig
>> @@ -195,6 +195,14 @@ config IPQ_GCC_9574
>>   	  i2c, USB, SD/eMMC, etc. Select this for the root clock
>>   	  of ipq9574.
>>   
>> +config IPQ_NSSCC_QCA8K
>> +        tristate "QCA8K(QCA8386 or QCA8084) NSS Clock Controller"
>> +        help
> 
> The 2 lines above should be indented with one tab (only; no spaces).
> 
>> +          Support for NSS(Network SubSystem) clock controller on
> 
> The line above should be indented with one tab + 2 spaces (like the following
> 3 lines).
> 
>> +	  qca8386/qca8084 chip.
>> +	  Say Y if you want to use network function of switch or PHY
>> +	  function. Select this for the root clock of qca8xxx.
> 
thanks Randy for the review, i will update the patch for this.