linux-kernel - RE: [PATCH 1/2] dt-bindings: ARM: at91: Document Microchip SAMA5D29 Curiosity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH8PR11MB6804073D5A1F26D8699756F8820BA@PH8PR11MB6804.namprd11.prod.outlook.com>
Date:   Wed, 2 Aug 2023 12:42:52 +0000
From:   <Mihai.Sain@...rochip.com>
To:     <conor@...nel.org>
CC:     <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <conor+dt@...nel.org>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <Claudiu.Beznea@...rochip.com>,
        <andre.przywara@....com>, <Andrei.Simion@...rochip.com>,
        <Jerry.Ray@...rochip.com>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <Cristian.Birsan@...rochip.com>
Subject: RE: [PATCH 1/2] dt-bindings: ARM: at91: Document Microchip SAMA5D29
 Curiosity

Hi Conor,

Please find bellow my answers.

Hey,

On Tue, Aug 01, 2023 at 02:11:50PM +0300, Mihai Sain wrote:
> From: Andrei Simion <andrei.simion@...rochip.com>
> 
> Document device tree binding of SAMA5D29 Curiosity, from Microchip.
> 
> Reviewed-by: Mihai Sain <mihai.sain@...rochip.com>
> Signed-off-by: Andrei Simion <andrei.simion@...rochip.com>

Your SoB is missing from here.

Sure, I will add my SoB.

> ---
>  Documentation/devicetree/bindings/arm/atmel-at91.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml 
> b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> index dfb8fd089197..89d75fbb1de4 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> @@ -79,6 +79,13 @@ properties:
>            - const: atmel,sama5d2
>            - const: atmel,sama5
>  
> +      - description: Microchip SAMA5D29 Curiosity
> +        items:
> +          - const: microchip,sama5d29-curiosity
> +          - const: atmel,sama5d29
> +          - const: atmel,sama5d2
> +          - const: atmel,sama5

What is the benefit of adding the two familial compatibles? Is there software that actually uses these?

Thanks,
Conor.

Currently there is no software.
In this file we've just documented the previous boards from sam9, sama5, sama7 MPUs.

Thanks,
Mihai

> +
>        - items:
>            - const: atmel,sama5d27
>            - const: atmel,sama5d2
> --
> 2.41.0
>