[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <41b9bbd2-e58f-810d-ad3b-715423ffe74b@linaro.org>
Date: Wed, 2 Aug 2023 14:49:56 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Rohit Agarwal <quic_rohiagar@...cinc.com>, agross@...nel.org,
andersson@...nel.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/8] arm64: dts: qcom: sdx75-idp: Add regulator nodes
On 2.08.2023 11:59, Rohit Agarwal wrote:
> Add the regulators found on SDX75 IDP.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@...cinc.com>
> ---
[...]
> + vreg_s2b_1p224: smps2 {
Even though most RPMh devices use the schematic-like names, I think naming
the labels like pmicname_regname, e.g. pm8550_l2 would be easier to read..
(Bjorn, Krzysztof - opinions?)
On top of that, please add labels to all of the regulators you're
introducing to limit unnecessary diff in the future.
Konrad
Powered by blists - more mailing lists