linux-kernel - Re: [PATCH 5/8] ARM: dts: qcom: sdx65-mtp: Update the pmic used in sdx65

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6653d101-c9d8-fff6-46af-149a2f28e4b6@quicinc.com>
Date:   Wed, 2 Aug 2023 18:47:22 +0530
From:   Rohit Agarwal <quic_rohiagar@...cinc.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>, <agross@...nel.org>,
        <andersson@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>
CC:     <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/8] ARM: dts: qcom: sdx65-mtp: Update the pmic used in
 sdx65


On 8/2/2023 6:16 PM, Konrad Dybcio wrote:
> On 2.08.2023 11:59, Rohit Agarwal wrote:
>> Update the pmic used in sdx65 platform to pm7250b.
>>
>> Signed-off-by: Rohit Agarwal <quic_rohiagar@...cinc.com>
>> ---
> Has this changed with a board revision? Was this wrong before?
>
> Need more explanation, and this definitely deserves a Fixes: tag.
Just went through the sdx65 pmics and found this mistake so updating here.
Although the validations were successful with the earlier pmic as well 
when originally pushed the patch.
Will add the fixes tag.

Thanks,
Rohit.
>
> Konrad
>>   arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
>> index 02d8d6e..fcf1c51 100644
>> --- a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
>> +++ b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
>> @@ -7,7 +7,7 @@
>>   #include "qcom-sdx65.dtsi"
>>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>   #include <arm64/qcom/pmk8350.dtsi>
>> -#include <arm64/qcom/pm8150b.dtsi>
>> +#include <arm64/qcom/pm7250b.dtsi>
>>   #include "qcom-pmx65.dtsi"
>>   
>>   / {