linux-kernel - Re: [PATCH 3/8] arm64: dts: qcom: Add PMIC pm7550ba dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d4ae6d7-5c87-c3c3-553c-807a12666d29@quicinc.com>
Date:   Wed, 2 Aug 2023 18:49:15 +0530
From:   Rohit Agarwal <quic_rohiagar@...cinc.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>, <agross@...nel.org>,
        <andersson@...nel.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>
CC:     <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/8] arm64: dts: qcom: Add PMIC pm7550ba dtsi


On 8/2/2023 6:44 PM, Konrad Dybcio wrote:
> On 2.08.2023 15:13, Rohit Agarwal wrote:
>> On 8/2/2023 6:12 PM, Konrad Dybcio wrote:
>>> On 2.08.2023 11:59, Rohit Agarwal wrote:
>>>> Add dtsi for PMIC pm7550ba found in Qualcomm platforms.
>>>>
>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@...cinc.com>
>>>> ---
>>> Subject: "PMIC pm7550ba" -> "pm7550ba PMIC"
>>>
>>> [...]
>>>
>>>> +
>>>> +        pm7550ba_eusb2_repeater: phy@...0 {
>>>> +            compatible = "qcom,pm8550b-eusb2-repeater";
>>> A new compatible should be introduced, so that it goes like this:
>>>
>>> compatible = "qcom,pm7550ba-eusb2-repeater", "qcom,pm8550b-eusb2-repeater";
>> Just a doubt, Since the compatible can be same why we need to introduce a new compatible.
>> Should every soc have a compatible string?
> If it turns out that we need to add a quirk for PM7550BA 3 years down
> the line, this approach lets us fix it for users that never updated
> their device trees.
Yes. Got it.

Thanks,
Rohit
>
> Konrad