linux-kernel - Re: [PATCH v8 11/19] sh: add <asm-generic/io.h> including

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <39c79971-12fc-41fc-8cae-b2a0089ed034@app.fastmail.com>
Date:   Wed, 02 Aug 2023 16:19:04 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "John Paul Adrian Glaubitz" <glaubitz@...sik.fu-berlin.de>,
        "Geert Uytterhoeven" <geert@...ux-m68k.org>,
        "Baoquan He" <bhe@...hat.com>
Cc:     linux-kernel@...r.kernel.org,
        "Andrew Morton" <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        "Christoph Hellwig" <hch@....de>,
        "Christophe Leroy" <christophe.leroy@...roup.eu>,
        "Mike Rapoport" <rppt@...nel.org>,
        "Matthew Wilcox" <willy@...radead.org>,
        "Alexander Gordeev" <agordeev@...ux.ibm.com>,
        "Kefeng Wang" <wangkefeng.wang@...wei.com>,
        "Niklas Schnelle" <schnelle@...ux.ibm.com>,
        "Stafford Horne" <shorne@...il.com>,
        "David Laight" <David.Laight@...lab.com>,
        "Helge Deller" <deller@....de>,
        "Nathan Chancellor" <nathan@...nel.org>,
        "Yoshinori Sato" <ysato@...rs.sourceforge.jp>,
        "Rich Felker" <dalias@...c.org>, linux-sh@...r.kernel.org,
        "Guenter Roeck" <linux@...ck-us.net>
Subject: Re: [PATCH v8 11/19] sh: add <asm-generic/io.h> including

On Tue, Aug 1, 2023, at 21:21, John Paul Adrian Glaubitz wrote:

>> I think ideally all the I/O port stuff in arch/sh/ could just be
>> removed after the conversion to asm-generic/io.h, but the
>> microdev_ioport_map() function oddity gets in the way of that,
>> unless someone wants to clean up that platform. As far as I
>> can tell, the ethernet, display, USB and PCI devices on it already
>> broke at some point (afbb9d8d5266b, 46bc85872040a), so it might
>> be easier to remove it entirely.
>
> I don't have this particular hardware, so I cannot comment on this.

Sure, as I explained, I'm pretty sure that nobody has
tried to boot this hardware in a long time, so I did not
expect you to have one.

I'll try to follow up with a patch to remove the platform
later on, based on the explations above.

>> Having the series go into linux-next sounds appropriate like this,
>> the entire purpose of that is to find such bugs and Andrew can jus
>> fold the fixup into the broken patch. 
>> 
>> Let me know if you prefer the simple version with the extra
>> #defines or if we should just use the generic inb/outb implementation
>> immediately and drop microdev in a separate patch.
>
> Please go ahead with the simple version.

Done,

     Arnd