[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230803132930.2742286-25-yukuai1@huaweicloud.com>
Date: Thu, 3 Aug 2023 21:29:25 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: song@...nel.org, xni@...hat.com
Cc: linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
yukuai3@...wei.com, yukuai1@...weicloud.com, yi.zhang@...wei.com,
yangerkun@...wei.com
Subject: [PATCH -next 24/29] md: suspend array in md_start_sync() if array need reconfiguration
From: Yu Kuai <yukuai3@...wei.com>
So that io won't concurrent with array reconfiguration, and now that
all callers of md_kick_rdev_from_array() suspend the array, change the
second parameter to true and prepare to remove the mddev_suspend() from
mddev_create/destroy_serial_pool().
Signed-off-by: Yu Kuai <yukuai3@...wei.com>
---
drivers/md/md.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index d5c061c87b2e..9bfa15b2fa97 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -9358,12 +9358,20 @@ static void md_start_sync(struct work_struct *ws)
{
struct mddev *mddev = container_of(ws, struct mddev, sync_work);
int spares = 0;
+ bool suspended = false;
+
+ if (md_spares_need_change(mddev)) {
+ __mddev_suspend(mddev);
+ suspended = true;
+ }
mddev_lock_nointr(mddev);
if (!md_is_rdwr(mddev)) {
remove_and_add_spares(mddev);
mddev_unlock(mddev);
+ if (suspended)
+ __mddev_resume(mddev);
return;
}
@@ -9412,6 +9420,9 @@ static void md_start_sync(struct work_struct *ws)
}
mddev_unlock(mddev);
+ if (suspended)
+ __mddev_resume(mddev);
+
md_wakeup_thread(mddev->sync_thread);
sysfs_notify_dirent_safe(mddev->sysfs_action);
md_new_event();
@@ -9424,6 +9435,8 @@ static void md_start_sync(struct work_struct *ws)
clear_bit(MD_RECOVERY_CHECK, &mddev->recovery);
clear_bit(MD_RECOVERY_RUNNING, &mddev->recovery);
mddev_unlock(mddev);
+ if (suspended)
+ __mddev_resume(mddev);
wake_up(&resync_wait);
if (test_and_clear_bit(MD_RECOVERY_RECOVER, &mddev->recovery) &&
--
2.39.2
Powered by blists - more mailing lists