linux-kernel - Re: [PATCH] efi/riscv: libstub: Fix comment about absolute relocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXECv+JU-ahvWENk4XRrjxkfBmWoWHhOSdwGpfxC1LVLkg@mail.gmail.com>
Date:   Thu, 3 Aug 2023 15:41:48 +0200
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Xiao Wang <xiao.w.wang@...el.com>
Cc:     linux-riscv@...ts.infradead.org, linux-efi@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] efi/riscv: libstub: Fix comment about absolute relocation

On Thu, 3 Aug 2023 at 07:48, Xiao Wang <xiao.w.wang@...el.com> wrote:
>
> We don't want absolute symbols references in the stub, so fix the double
> negation in the comment.
>
> Fixes: d7071743db31 ("RISC-V: Add EFI stub support.")
> Cc: stable@...r.kernel.org
> Signed-off-by: Xiao Wang <xiao.w.wang@...el.com>

Queued up in efi/next (without the cc stable)

Thanks,


> ---
>  drivers/firmware/efi/libstub/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile
> index b0f8c495c10f..ed6e8ebd89b4 100644
> --- a/drivers/firmware/efi/libstub/Makefile
> +++ b/drivers/firmware/efi/libstub/Makefile
> @@ -146,7 +146,7 @@ STUBCOPY_RELOC-$(CONFIG_ARM64)      := R_AARCH64_ABS
>
>  # For RISC-V, we don't need anything special other than arm64. Keep all the
>  # symbols in .init section and make sure that no absolute symbols references
> -# doesn't exist.
> +# exist.
>  STUBCOPY_FLAGS-$(CONFIG_RISCV) += --prefix-alloc-sections=.init \
>                                    --prefix-symbols=__efistub_
>  STUBCOPY_RELOC-$(CONFIG_RISCV) := R_RISCV_HI20
> --
> 2.25.1
>