[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAMRc=MdNovdNeExP9MSyun+bwfaE-xyEO8SPuHVOPLNQ5opWUg@mail.gmail.com>
Date: Thu, 3 Aug 2023 15:45:23 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Andrei Coardos <aboutphysycs@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
andy@...nel.org, linus.walleij@...aro.org,
Alexandru Ardelean <alex@...uggie.ro>
Subject: Re: [PATCH] gpio: timberdale: remove unneeded call to platform_set_drvdata()
On Tue, Aug 1, 2023 at 9:32 AM Andrei Coardos <aboutphysycs@...il.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> ---
> drivers/gpio/gpio-timberdale.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-timberdale.c b/drivers/gpio/gpio-timberdale.c
> index de14949a3fe5..bbd9e9191199 100644
> --- a/drivers/gpio/gpio-timberdale.c
> +++ b/drivers/gpio/gpio-timberdale.c
> @@ -256,8 +256,6 @@ static int timbgpio_probe(struct platform_device *pdev)
> if (err)
> return err;
>
> - platform_set_drvdata(pdev, tgpio);
> -
> /* make sure to disable interrupts */
> iowrite32(0x0, tgpio->membase + TGPIO_IER);
>
> --
> 2.34.1
>
Applied, thanks!
Bart
Powered by blists - more mailing lists