linux-kernel - Re: [PATCH] gpio: tqmx86: remove unneeded call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MfCqNSNyKspKFPQNTC9BTFgcZ4kuRJcsxJSCf8CmqeVrg@mail.gmail.com>
Date:   Thu, 3 Aug 2023 15:48:47 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Andrei Coardos <aboutphysycs@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        andy@...nel.org, linus.walleij@...aro.org,
        Alexandru Ardelean <alex@...uggie.ro>
Subject: Re: [PATCH] gpio: tqmx86: remove unneeded call to platform_set_drvdata()

On Tue, Aug 1, 2023 at 10:43 PM Andrei Coardos <aboutphysycs@...il.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> ---
>  drivers/gpio/gpio-tqmx86.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tqmx86.c b/drivers/gpio/gpio-tqmx86.c
> index 6f8bd1155db7..3a28c1f273c3 100644
> --- a/drivers/gpio/gpio-tqmx86.c
> +++ b/drivers/gpio/gpio-tqmx86.c
> @@ -277,8 +277,6 @@ static int tqmx86_gpio_probe(struct platform_device *pdev)
>
>         tqmx86_gpio_write(gpio, (u8)~TQMX86_DIR_INPUT_MASK, TQMX86_GPIODD);
>
> -       platform_set_drvdata(pdev, gpio);
> -
>         chip = &gpio->chip;
>         chip->label = "gpio-tqmx86";
>         chip->owner = THIS_MODULE;
> --
> 2.34.1
>

Applied, thanks!

Bart