linux-kernel - Re: [PATCH 2/4] net: ti: icss-iep: Add IEP driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Aug 2023 17:16:59 +0200
From:   Simon Horman <horms@...nel.org>
To:     MD Danish Anwar <danishanwar@...com>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Roger Quadros <rogerq@...nel.org>,
        Vignesh Raghavendra <vigneshr@...com>,
        Andrew Lunn <andrew@...n.ch>,
        Richard Cochran <richardcochran@...il.com>,
        Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>, nm@...com, srk@...com,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        netdev@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/4] net: ti: icss-iep: Add IEP driver

On Thu, Aug 03, 2023 at 04:31:51PM +0530, MD Danish Anwar wrote:
> From: Roger Quadros <rogerq@...com>
> 
> Add a driver for Industrial Ethernet Peripheral (IEP) block of PRUSS to
> support timestamping of ethernet packets and thus support PTP and PPS
> for PRU ethernet ports.
> 
> Signed-off-by: Roger Quadros <rogerq@...com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@...com>
> Signed-off-by: Murali Karicheri <m-karicheri2@...com>
> Signed-off-by: Vignesh Raghavendra <vigneshr@...com>
> Signed-off-by: MD Danish Anwar <danishanwar@...com>

...

> +static int icss_iep_pps_enable(struct icss_iep *iep, int on)
> +{
> +	int ret = 0;
> +	struct timespec64 ts;
> +	struct ptp_clock_request rq;
> +	unsigned long flags;
> +	u64 ns;

For networking code, please arrange local variables in reverse xmas tree
order - longest line to shortest.

https://github.com/ecree-solarflare/xmastree is your friend here.

...