linux-kernel - Re: [PATCH] net/ethernet/realtek: Add Realtek automotive PCIe driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87194ec9-476a-471b-a5b5-d70e8a2cbcd5@lunn.ch>
Date:   Thu, 3 Aug 2023 17:49:45 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     justinlai0215 <justinlai0215@...ltek.com>, kuba@...nel.org,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net/ethernet/realtek: Add Realtek automotive PCIe driver

On Thu, Aug 03, 2023 at 10:57:29AM +0200, Jiri Pirko wrote:
> Thu, Aug 03, 2023 at 10:25:13AM CEST, justinlai0215@...ltek.com wrote:
> >This patch is to add the ethernet device driver for the PCIe interface of Realtek Automotive Ethernet Switch,
> >applicable to RTL9054, RTL9068, RTL9072, RTL9075, RTL9068, RTL9071.
> >
> >Signed-off-by: justinlai0215 <justinlai0215@...ltek.com>
> 
> [...]
> 
> 
> >+
> >+static long rtase_swc_ioctl(struct file *p_file, unsigned int cmd, unsigned long arg)
> 
> There are *MANY* thing wrong in this patch spotted just during 5 minutes
> skimming over the code, but this definitelly tops all of them.
> I didn't see so obvious kernel bypass attempt for a long time. Ugh, you
> can't be serious :/
> 
> I suggest to you take couple of rounds of consulting the patch with
> some skilled upstream developer internaly before you make another
> submission in order not not to waste time of reviewers.

I have to agree with Jiri here. This 'vendor crap' driver has no
chance of being merged as is. You need to reach out to some
experienced mainline driver developers to help you rewrite it to
mainline quality.

    Andrew

---
pw-bot: cr