[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230803160828.GA223746@cmpxchg.org>
Date: Thu, 3 Aug 2023 12:08:28 -0400
From: Johannes Weiner <hannes@...xchg.org>
To: Lucas Karpinski <lkarpins@...hat.com>
Cc: Michal Hocko <mhocko@...nel.org>,
Roman Gushchin <roman.gushchin@...ux.dev>,
Shakeel Butt <shakeelb@...gle.com>,
Muchun Song <muchun.song@...ux.dev>, Tejun Heo <tj@...nel.org>,
Zefan Li <lizefan.x@...edance.com>,
Shuah Khan <shuah@...nel.org>, cgroups@...r.kernel.org,
linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] selftests: cgroup: fix test_kmem_basic slab1 check
On Thu, Aug 03, 2023 at 12:00:47PM -0400, Lucas Karpinski wrote:
> test_kmem_basic creates 100,000 negative dentries, with each one mapping
> to a slab object. After memory.high is set, these are reclaimed through
> the shrink_slab function call which reclaims all 100,000 entries. The
> test passes the majority of the time because when slab1 is calculated,
> it is often above 0, however, 0 is also an acceptable value.
>
> Signed-off-by: Lucas Karpinski <lkarpins@...hat.com>
Acked-by: Johannes Weiner <hannes@...xchg.org>
> @@ -71,7 +71,7 @@ static int test_kmem_basic(const char *root)
>
> cg_write(cg, "memory.high", "1M");
> slab1 = cg_read_key_long(cg, "memory.stat", "slab ");
> - if (slab1 <= 0)
> + if (slab1 < 0)
> goto cleanup;
This conflicts with a recent patch already queued up in -mm:
selftests: cgroup: fix test_kmem_basic false positives
which adds a sleep(1) between cg_write() and cg_read_key_long().
Can you please rebase on top of
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
and re-send the patch with
To: Andrew Morton <akpm@...ux-foundation.org>
? Thanks
Powered by blists - more mailing lists