linux-kernel - Re: [PATCH] rcu: include torture_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10180121-4584-463a-af52-1005b23271e7@paulmck-laptop>
Date:   Thu, 3 Aug 2023 09:32:38 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Joel Fernandes <joel@...lfernandes.org>
Cc:     Arnd Bergmann <arnd@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Frederic Weisbecker <frederic@...nel.org>,
        Neeraj Upadhyay <quic_neeraju@...cinc.com>,
        Josh Triplett <josh@...htriplett.org>,
        Boqun Feng <boqun.feng@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Zqiang <qiang.zhang1211@...il.com>,
        Zhen Lei <thunder.leizhen@...wei.com>, rcu@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rcu: include torture_sched_setaffinity() declaration

On Thu, Aug 03, 2023 at 12:02:52PM -0400, Joel Fernandes wrote:
> On Thu, Aug 3, 2023 at 10:40 AM Arnd Bergmann <arnd@...nel.org> wrote:
> >
> > From: Arnd Bergmann <arnd@...db.de>
> >
> > The prototype for torture_sched_setaffinity() moved to a
> > different header, which needs to be included from update.c
> > to avoid this W=1 warning:
> >
> > kernel/rcu/update.c:529:6: error: no previous prototype for 'torture_sched_setaffinity' [-Werror=missing-prototypes]
> >   529 | long torture_sched_setaffinity(pid_t pid, const struct cpumask *in_mask)
> >
> > Fixes: 521ec59e5453e ("torture: Move rcutorture_sched_setaffinity() out of rcutorture")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Reviewed-by: Joel Fernandes (Google) <joel@...lfernandes.org>

Queued (likely for the v6.7 merge window), thank you both!

							Thanx, Paul

> thanks,
> 
> - Joel
> 
> 
> > ---
> >  kernel/rcu/update.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c
> > index 0533b510f0a8..c534d6806d3d 100644
> > --- a/kernel/rcu/update.c
> > +++ b/kernel/rcu/update.c
> > @@ -25,6 +25,7 @@
> >  #include <linux/interrupt.h>
> >  #include <linux/sched/signal.h>
> >  #include <linux/sched/debug.h>
> > +#include <linux/torture.h>
> >  #include <linux/atomic.h>
> >  #include <linux/bitops.h>
> >  #include <linux/percpu.h>
> > --
> > 2.39.2
> >